Prevent clear and in-place operators from mutating frozen BoxLists - #327
Closed
vitalivo wants to merge 1 commit into
Closed
Prevent clear and in-place operators from mutating frozen BoxLists#327vitalivo wants to merge 1 commit into
vitalivo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
BoxList([1, 2], frozen_box=True)can still be modified withclear(),+= [3], or*= 2(including*= 0). These operations bypass the frozen checks and can change the hash of an object already used as a dictionary key.Block
clearalongside the other frozen methods and checkfrozen_boxin the two in-place special methods, which Python resolves on the class. Mutable lists retain their existing behavior. Four regression cases fail before the fix; they also check unchanged contents/hash after rejection and the corresponding mutable operations.Validation: all 163 tests pass on Python 3.13 with the optional serialization dependencies, including toon-format. Includes changelog and contributor updates; targets
developas requested by CONTRIBUTING.rst.