Skip to content

Update depositAddress to use sapi instead of wapi #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuzzzzaah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update depositAddress to use sapi instead of wapi #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions node-binance-api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,12 +667,12 @@ declare module "node-binance-api" {
depositHistory(...args: any): any;

/**
* Get the deposit history for given asset
* @param {string} asset - the asset
* Get the deposit history for given asset/coin
* @param {string} coin - the asset/coin
* @param {function} callback - the callback function
* @return {promise or undefined} - omitting the callback returns a promise
*/
depositAddress(asset: string, callback?: _callback): Promise<any>;
depositAddress(coin: string, callback?: _callback): Promise<any>;
depositAddress(...args: any): any;

/**
Expand Down
6 changes: 3 additions & 3 deletions node-binance-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3483,7 +3483,7 @@ let api = function Binance( options = {} ) {
* @param {function} callback - the callback function
* @return {promise or undefined} - omitting the callback returns a promise
*/
depositAddress: function ( asset, callback ) {
depositAddress: function ( coin, callback ) {
if ( !callback ) {
return new Promise( ( resolve, reject ) => {
callback = ( error, response ) => {
Expand All @@ -3493,10 +3493,10 @@ let api = function Binance( options = {} ) {
resolve( response );
}
}
signedRequest( wapi + 'v3/depositAddress.html', { asset: asset }, callback );
signedRequest( sapi + 'v1/capital/deposit/address', { coin }, callback );
} )
} else {
signedRequest( wapi + 'v3/depositAddress.html', { asset: asset }, callback );
signedRequest( sapi + 'v1/capital/deposit/address', { coin }, callback );
}
},

Expand Down
6 changes: 3 additions & 3 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,8 +796,8 @@ describe('Deposit address', function () {
assert(Object.prototype.hasOwnProperty.call(result, 'address'), WARN_SHOULD_HAVE_KEY + 'address');
assert(Object.prototype.hasOwnProperty.call(result, 'success'), WARN_SHOULD_HAVE_KEY + 'success');
assert(Object.prototype.hasOwnProperty.call(result, 'addressTag'), WARN_SHOULD_HAVE_KEY + 'addressTag');
assert(Object.prototype.hasOwnProperty.call(result, 'asset'), WARN_SHOULD_HAVE_KEY + 'asset');
assert(result.asset === 'BTC');
assert(Object.prototype.hasOwnProperty.call(result, 'coin'), WARN_SHOULD_HAVE_KEY + 'coin');
assert(result.coin === 'BTC');
assert(result.success === true);
done();
});
Expand All @@ -814,7 +814,7 @@ describe('Deposit address', function () {
assert(Object.prototype.hasOwnProperty.call(result, 'address') === false, WARN_SHOULD_NOT_HAVE_KEY + 'address');
assert(Object.prototype.hasOwnProperty.call(result, 'success'), WARN_SHOULD_NOT_HAVE_KEY + 'success');
assert(Object.prototype.hasOwnProperty.call(result, 'addressTag') === false, WARN_SHOULD_NOT_HAVE_KEY + 'addressTag');
assert(Object.prototype.hasOwnProperty.call(result, 'asset') === false, WARN_SHOULD_NOT_HAVE_KEY + 'asset');
assert(Object.prototype.hasOwnProperty.call(result, 'coin') === false, WARN_SHOULD_NOT_HAVE_KEY + 'coin');
assert(result.success === false);
done();
});
Expand Down