chore(deps): require laravel-telemetry ^2.4 - #1
Merged
Merged
Conversation
The overlay was pinned to ^1.0, so it never saw telemetry 2.x. Raised to ^2.4 and verified against 2.4.0: 77 tests, pint and PHPStan clean, no code change needed for the API — the 2.0 breaks were semantic, not signatures. One of them did reach us. Telemetry 2.0 dropped enduser.* (deprecated in semconv 1.27) for user.id/user.type/user.guard, which left the overlay's enduser.roles/groups/super as the only enduser.* keys on the span — two vocabularies on one trace, which is exactly what the naming invariant forbids. Renamed to user.roles/user.groups/user.super, with docs, config comments, SECURITY.md and tests moved with them. Breaking for anyone querying the old attribute names, so the next release is a major. Also fixed a README install block two majors stale (^0.2.0, described as 0.x SemVer) and a CI comment claiming telemetry resolves from a vcs entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlay was pinned to
cboxdk/laravel-telemetry: ^1.0, so it never resolved 2.x — and telemetry is now at v2.4.0.Verified against 2.4.0
composer updateresolves v1.0.0 → v2.4.0. Suite passes unchanged: 77 tests / 172 assertions, pint clean, PHPStan (level max, 1G) clean. No signature broke — telemetry 2.0's breaking changes were semantic (attribute and metric names), not API shape. Every hook the overlay uses (resolveUserUsing,resolveRouteUsing,enrichRequestsUsing,classifyCacheKeysUsing,recordSpan,bumpStat, the cache recorders) is intact.One semantic break did reach us
Telemetry 2.0 dropped
enduser.*— deprecated in semconv 1.27 — foruser.id/user.type/user.guard. That left the overlay'senduser.roles,enduser.groupsandenduser.superas the onlyenduser.*keys on the span: a trace would carryuser.idfrom the base package next toenduser.rolesfrom the overlay. Two vocabularies on one trace is exactly what the naming invariant exists to prevent, so they move too:enduser.rolesuser.rolesenduser.groupsuser.groupsenduser.superuser.superuser.rolesis in the OTel registry;user.groups/user.superare overlay-specific but now sit in the same namespace as everything else on the span. Docs, config comments, SECURITY.md and tests moved with them.This is breaking for anyone whose TraceQL queries, dashboards or collector processors key on the old names, and for apps composing their own resolver on top of
Hooks::userAttributes(). The next overlay release is therefore a major.Drive-by
cboxdk/statamic-telemetry:^0.2.0and described the package as 0.x SemVer — two majors stale since 1.0.0.Not in this PR
extra.branch-alias, still1.0.x-dev) is yours.recordedMetrics()test API. The overlay's own tests could use it to pin label sets, but that is a separate change.composer auditreports threestatamic/cmsadvisories (two fixed in 6.24.2, one with no fix as of 6.30.0). Pre-existing, unrelated to this bump, andstatamic/cmsis the host's dependency, not ours to pin.