Skip to content

Ensure TraceLogger log level is maintained property #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Youssef1313 wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −0
Open

Ensure TraceLogger log level is maintained property #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0218a47
Ensure TraceLogger log level is maintained property
Youssef1313 May 2, 2026
af3c27c
Ensure it's all preserved even
Youssef1313 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Castle.Core.Tests/DynamicProxy.Tests/LoggingTestCase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,16 @@ public void ExcludedNonVirtualMethods()
"Castle.DynamicProxy.Tests.LoggingTestCase+NonVirtualMethodClass because it cannot be intercepted."));
}

[Test]
public void LogsWarningOnlyByDefault()
{
var generator = new ProxyGenerator();
Assert.IsInstanceOf<TraceLogger>(generator.Logger);

var logger = (TraceLogger)generator.Logger;
Assert.AreEqual(LoggerLevel.Warn, logger.Level);
}

#region Test Types

public interface IEmptyInterface
Expand Down
2 changes: 2 additions & 0 deletions src/Castle.Core/Core/Logging/TraceLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ private void Initialize()

var defaultLevel = MapSourceLevels(Level);
traceSource = new TraceSource(Name, defaultLevel);
traceSource.Switch.Level = defaultLevel;

// no further action necessary when the named source is configured
if (IsSourceConfigured(traceSource))
Expand All @@ -134,6 +135,7 @@ private void Initialize()

// reconfigure the created source to act like the found source
traceSource.Switch = foundSource.Switch;
traceSource.Switch.Level = defaultLevel;
traceSource.Listeners.Clear();
foreach (TraceListener listener in foundSource.Listeners)
{
Expand Down