Skip to content

Log completed password resets as $profile_reset #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartes merged 2 commits into from
Sep 8, 2026
Merged

Log completed password resets as $profile_reset #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd1dda
Send completed password resets as $profile_reset on Risk
bartes Sep 8, 2026
b88f2fe
Log completed password resets as $profile_reset
bartes Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/users/password_resets_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def create
status = current_user.valid_password?(params[:password].to_s) ? '$failed' : '$succeeded'

payload = {
type: '$password_reset',
type: '$profile_reset',
status: status,
request_token: castle_request_token,
user: { id: current_user.id.to_s, email: current_user.email }
Expand Down
4 changes: 2 additions & 2 deletions app/views/users/password_resets/show.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
%p.text-muted{ class: 'text-[0.9rem]' }
Assume the user already passed your reset challenge (e.g. an emailed OTP).
Enter a value different from your current password to send
%code $password_reset / $succeeded
%code $profile_reset / $succeeded
\, or your current password to send
%code $password_reset / $failed
%code $profile_reset / $failed
\. (The password is not actually changed.)

.card.mt-4{ class: 'max-w-[640px]' }
Expand Down
6 changes: 3 additions & 3 deletions spec/controllers/users/password_resets_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@

it { expect(response).to render_template(:show) }

it 'logs $password_reset / $succeeded' do
it 'logs $profile_reset / $succeeded' do
expect(controller.castle).to have_received(:log).with(
type: '$password_reset',
type: '$profile_reset',
status: '$succeeded',
request_token: nil,
user: { id: user.id.to_s, email: user.email }
Expand All @@ -57,7 +57,7 @@
post :create, params: { password: 'current-password-1' }
end

it 'logs $password_reset / $failed' do
it 'logs $profile_reset / $failed' do
expect(controller.castle).to have_received(:log).with(hash_including(status: '$failed'))
end
end
Expand Down