Repository navigation
fix(image-expander): render lightbox above navbar - #10
Merged
Merged
Conversation
…of clean neutrals
…and dark mode dots
…k mode elevation highlights
…ansition freezing
… Skeleton, Breadcrumb, and Textarea
…timize responsive grid
…hes and generous spacing
Render the dialog via createPortal into document.body and raise z-index to 1100 (Modal level) so the sticky Navbar (z-1000) no longer covers the overlay and close button. Adds dialog ARIA attributes.
✅ Deploy Preview for dashkit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ImageExpander lightbox used z-[100] and rendered inline, so the sticky Navbar (z-[1000]) covered the overlay and hid the close button.
createPortalintodocument.body(same pattern as Modal/Drawer).image-expander__dialogtoz-[1100]role=dialog,aria-modal,aria-labeland a labeled close buttonbun run check:allpasses locally.