Skip to content

Let the catalog type-check resolve @cardstack/bxl - #6627

Merged
richardhjtan merged 1 commit into
mainfrom
cs-13687-bxl-for-catalog-type-check
Oct 12, 2026
Merged

richardhjtan merged 1 commit into
mainfrom
cs-13687-bxl-for-catalog-type-check

Conversation

@richardhjtan

@richardhjtan richardhjtan commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Merge order: this, then cardstack/boxel-catalog#829.
Merge this first, then cardstack/boxel-catalog#829 right after.

Merges before: cardstack/boxel-catalog#829

Background and Goal

Card modules import @cardstack/bxl (the host shims it for computeVia formulas), but packages/catalog didn't depend on it, so the catalog's lint:types couldn't resolve the import. This adds the workspace dependency, which lets the BXL formula blocks move into the catalog (CS-13687).

🤖 Generated with Claude Code

Card modules import @cardstack/bxl, which the host shims at runtime, but
packages/catalog didn't depend on it, so the catalog's lint:types couldn't
resolve the import.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@richardhjtan
richardhjtan requested a review from a team October 9, 2026 08:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T08:27:29.009559Z 2a59879 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Host Test Results

    1 files      1 suites   1h 26m 26s ⏱️
5 217 tests 5 206 ✅ 11 💤 0 ❌
5 232 runs  5 221 ✅ 11 💤 0 ❌

Results for commit 2a59879.

Realm Server Test Results

    1 files    319 suites   1h 49m 40s ⏱️
5 106 tests 5 106 ✅ 0 💤 0 ❌
5 165 runs  5 165 ✅ 0 💤 0 ❌

Results for commit 2a59879.

@richardhjtan
richardhjtan merged commit 8c0f8b6 into main Oct 12, 2026
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants