Fix Switch keyboard activation, focus ring, and thumb geometry - #5825
Draft
burieberry wants to merge 1 commit into
Draft
Fix Switch keyboard activation, focus ring, and thumb geometry#5825burieberry wants to merge 1 commit into
burieberry wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the boxel-ui Switch per CS-12328:
changebinding replaces theclick+keypresspair, which double-fired on Space and made the switch keyboard-inoperable; Enter (inert on checkboxes) gets its own keydown path:focus-visiblering on the label; the UA halo on the inner input is suppressedtranslateX(width − height)instead ofmargin-left: 49%— flush right at any size/border/padding, animated viatransformonChangepasses the new state (() => voidcallers stay assignable);aria-checkedrenders as explicit'true'/'false'instead of vanishing when false--boxel-border-radius-pilltoken; the track uses itSwitchSiganturetypo fixedVerified through the homepage mode toggle: Space, Enter, and click each toggle exactly once; ring draws on the control; thumb lands flush at both ends. The boxel-home consumer workarounds are removed in a follow-up there, which should land after this deploys.
🤖 Generated with Claude Code