Replace virtualNetworkFor with resolveInstanceURL#5400
Draft
backspace wants to merge 1 commit into
Draft
Conversation
Contributor
…S-11778) Card definitions (spec.gts, experiments-realm/asset.gts) reached the store's VirtualNetwork via the `virtualNetworkFor` export purely to turn an RRI/relative reference into a real fetchable URL for a boundary that can't consume RRI (an `<img src>`, the AI source-file reader's `new URL(...)`). Replace that export with a narrow `resolveInstanceURL(instance, reference)` that returns a URL, not the VirtualNetwork itself — closing the raw-VN leak to card definitions. It resolves through the active Loader's VirtualNetwork (the network boundary). Scope note: the CardStore.virtualNetwork interface member stays for now. Beyond the two loadCardDocument fetch boundaries it is still read by query-field-support (resolveQueryAndRealm) and host search (isFileDefCodeRef), which need the raw VirtualNetwork for operations resolveInstanceURL doesn't cover. Removing the interface member is deferred to a follow-up that migrates those consumers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
backspace
force-pushed
the
cs-11778-card-api-replace-virtualnetworkfor-with-a-narrow
branch
from
d73667a to
b308f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #5393.