Ship a semantic token layer with dark mode in boxel-ui#5394
Draft
burieberry wants to merge 1 commit into
Draft
Conversation
Own the semantic design tokens in the addon instead of leaving them to consumers: - theme.css (new): defines the full semantic contract (--primary, --foreground, --muted, --card, --border, --destructive, --sidebar-*, shadows, etc.) mapped onto the --boxel-* palette as a default light theme, plus a dark theme via .dark / [data-theme="dark"] and an opt-in [data-theme="system"] scope. Also emits an inherited --boxel-color-scheme signal for cards to key off. - variables.css: mark the raw --boxel-* palette as an internal implementation detail; component/card styles should consume the semantic tokens. - button, multi-select: migrate bare palette border refs onto var(--border, ...).
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Own the semantic design tokens in the addon instead of leaving them to consumers: