Support .md skill files as user-configurable default skills#5392
Draft
lukemelia wants to merge 1 commit into
Draft
Support .md skill files as user-configurable default skills#5392lukemelia wants to merge 1 commit into
lukemelia wants to merge 1 commit into
Conversation
Add a `defaultSkills` field to `SystemCard` so a user's active system card supplies the skills enabled by default in new AI assistant rooms, referencing `.md` skill files (`MarkdownDef` with `boxel.kind: skill` frontmatter). - SystemCard: `defaultSkills = linksToMany(MarkdownDef)` + a "Default Skills" section in the isolated view. - `loadDefaultSkills(submode)` now returns skill ids — from the system card's `defaultSkills` when set (mode-agnostic), else the hardcoded fallback, which is repointed from legacy `Skill/*` cards to `skills/*/SKILL.md`. - Room creation resolves skill ids kind-agnostically (`.md` files or legacy `Skill` cards) via `loadSkillSource`, splitting card vs file uploads; `CreateAIAssistantRoomInput` gains `enabledSkillIds`/`disabledSkillIds`. - "Add same skills" is now id-based so `.md` skills survive that flow. - Seed the default SystemCard with the three default `.md` skills. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 15m 5s ⏱️ Results for commit 4635503. For more details on these errors, see this check. Realm Server Test Results 1 files 1 suites 9m 50s ⏱️ Results for commit 4635503. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lets a user's active System Card supply the skills enabled by default in new AI assistant rooms, referencing the new
.mdskill files (MarkdownDefwhoseboxel.kind: skillfrontmatter makes them a skill source) rather than only legacySkillcards.Previously the default LLM model for new rooms came from the user's system card, but default skills were a hardcoded list in the host pointing at
Skill/*.jsoncards — not user-configurable and card-only.Changes
SystemCard— newdefaultSkills = linksToMany(MarkdownDef)field + a "Default Skills" section in the isolated view.loadDefaultSkills(submode)now returns skill ids: the system card'sdefaultSkillswhen set (applied to every new room, mode-agnostic), otherwise the hardcoded fallback — which is repointed from legacySkill/*cards toskills/*/SKILL.md.CreateAIAssistantRoomInputgainsenabledSkillIds/disabledSkillIds;create-ai-assistant-roomresolves ids kind-agnostically vialoadSkillSource(splitting.mdfile uploads vsSkillcard uploads, gathering commands viagetSkillSourceCommands) and bakes them into the room's initial state..mdskills survive that flow (previously dropped by anisCardInstancefilter).SystemCardinstance (catalog realm) is populated with the three default.mdskills via universal@cardstack/skills/...refs. (Committed separately in the catalog contents repo.)When a user has no system card, or it lists no skills, new rooms fall back to the (now
.md) hardcoded defaults — no regression out of the box.Verification
ember-tsc --noEmit) clean across host app + tests..gts"parse errors" under bare/lint-staged eslint are a known content-tag-preprocessor artifact (reproduce on untouched.gts); the glint path is clean..mdskills).Notes / follow-ups
system-card.d.tsis a gitignored build artifact, regenerated from the source change.default.jsonseed lives in the nested catalog contents repo and needs its own PR/commit.defaultSkills, and thatlinksToMany defaultSkillsids are available on the loaded system card at room-creation time.🤖 Generated with Claude Code