CS-11047: Consolidate workspace-sync-cli integration tests into boxel-cli CI job#4853
Draft
FadhlanR wants to merge 1 commit into
Draft
Conversation
…-cli CI job Folds workspace-sync-cli's qunit integration suite into the boxel-cli vitest suite and removes the standalone `workspace-sync-cli-test` CI job. The `workspace-sync-cli-build` job and the package source stay (out of scope per the ticket). Audit of the seven qunit cases: - Cases 1-4 (pull, push, pull --delete, push --dry-run): already covered by existing boxel-cli specs — dropped to avoid duplicate coverage. - Case 5 (.realm.json bidirectional): deliberately inverted by design. boxel-cli treats .realm.json as a protected file and never syncs it; CS-11131 phases the sidecar out entirely. - Case 6 (REALM_SECRET_SEED password derivation): N/A. boxel-cli captures credentials via `boxel profile add`; no equivalent code path. - Case 7 (.boxelignore patterns): ported as a new `it(...)` in `realm-push.test.ts` — boxel-cli supports .boxelignore (realm-sync-base.ts) but had no integration coverage for it. The spawn-based `start-test-realm.ts` helper is replaced by boxel-cli's in-process `startTestRealmServer` (stronger cleanup, no IPC handshake). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace-sync-cli-testCI job.workspace-sync-cli-buildand the package source stay (explicitly out of scope per the ticket).Linear: CS-11047
Plan doc:
docs/cs-11047-consolidate-workspace-sync-cli-tests-plan.mdPer-case audit verdict
realm-pull.test.ts:56realm-push.test.ts:153, 194--deleteremoves extrasrealm-pull.test.ts:123--dry-runmodifies nothingrealm-push.test.ts:328.realm.jsonbidirectional sync.realm.jsonas protected; CS-11131 phases the sidecar out. Existing inverse coverage atrealm-sync.test.ts:441("protected files (.realm.json) are never synced").REALM_SECRET_SEEDpassword derivationboxel profile addfor credentials; no equivalent code path..boxelignorepatternsit(...)inrealm-push.test.ts. boxel-cli supports.boxelignore(src/lib/realm-sync-base.ts:697) but had no integration coverage.What got deleted
packages/workspace-sync-cli/tests/(integration-test.ts, helpers/start-test-realm.ts, index.ts, README.md).testscript +qunit/@types/qunitdevDeps frompackages/workspace-sync-cli/package.json.packages/workspace-sync-cli/.eslintrc.js.workspace-sync-cli-testjob (and its deadtest-web-assetsif:clause) in.github/workflows/ci.yaml.The spawn-based
start-test-realm.tsis replaced by boxel-cli's in-processstartTestRealmServer— stronger cleanup, no IPC handshake (the same shape that caused the flake fixed in2950dfd256).Test plan
pnpm lintinpackages/workspace-sync-cli— clean.pnpm buildinpackages/boxel-cli— clean.pnpm test:unitinpackages/boxel-cli— 206/206 pass.pnpm test:integrationinpackages/boxel-cli(targetedrealm-push.test.ts) — 20/20 pass; new.boxelignorecase verified (count went from 19 → 20).Boxel CLI Testspasses,Workspace Sync CLI Buildstill present and passes,Workspace Sync CLI Integration Testsis gone.🤖 Generated with Claude Code