DRAFT: Submission bot opens a github PR #4044
DRAFT: Submission bot opens a github PR #4044tintinthong wants to merge 2 commits intoget-bot-runner-to-run-headless-commandfrom
Conversation
tintinthong
changed the base branch from
main
to
get-bot-runner-to-run-headless-command
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 935b2c0665
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let prParams: Parameters<CreatePullRequest>[0] = { | ||
| ...params, | ||
| head: HARDCODED_PR_HEAD_BRANCH, | ||
| }; |
There was a problem hiding this comment.
openPullRequest currently replaces params.head with a hardcoded branch, so every PR is opened from test-submissions regardless of the event/listing-specific branch passed by callers. This breaks branch isolation and can open the wrong PR (or fail if that branch is absent), which makes the submission flow unreliable for any room-specific listing updates.
Useful? React with 👍 / 👎.
| if (eventContent.type === 'pr-listing-create') { | ||
| // Temporary workaround: handle PR creation directly until this flow is moved to a proper command path. | ||
| await openCreateListingPR({ | ||
| eventContent, |
There was a problem hiding this comment.
For pr-listing-create, this function calls openCreateListingPR but then continues into the generic enqueue path instead of exiting, so the same trigger can both open a PR directly and enqueue a run-command job. In environments where that event type has an allowed command registration, this causes duplicated/competing side effects for a single Matrix event.
Useful? React with 👍 / 👎.
Preview deployments |
1 participant
No description provided.