Repository navigation
ci: read the Context7 error field with jq - #85
Merged
Merged
Conversation
Same fix as review feedback on solid-objects-js#65. The too-early check matched
the exact string "error":"too-early", so valid JSON with other
spacing, such as {"error": "too-early"}, would fail the job instead
of skipping. Read the field with jq. On four sample bodies, grep
missed the spaced form and jq skipped it, and both still fail on
another error and on a body that is not JSON. Against the live API
the workflow script still exits 0 with the notice.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as the review feedback on cardmagic/solid-objects-js#65. The too-early check in the Context7 refresh workflow matched the exact string
"error":"too-early", so valid JSON with other spacing would fail the job instead of skipping. The workflow now reads the field withjq -e '.error == "too-early"'.Validation
actionlintpasses.grepmissed{"error": "too-early"}andjqskipped it. Both still fail on another error and on a body that is not JSON.