integration of impact overlay and base system - #88
Open
ccp-intern wants to merge 2 commits into
Open
Conversation
cleanup Update EveChildInstancedMeshes.cpp
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/trinity/Eve/SpaceObject/EveSpaceObject2.h b/trinity/Eve/SpaceObject/EveSpaceObject2.h
index 5e11408..b77b530 100644
--- a/trinity/Eve/SpaceObject/EveSpaceObject2.h
+++ b/trinity/Eve/SpaceObject/EveSpaceObject2.h
@@ -314 +314 @@ public:
- void CollectPartDamageOverlays( std::vector<std::pair<EveDamageOverlay*, int32_t>>& out );
+ void CollectPartDamageOverlays( std::vector<std::pair<EveDamageOverlay*, int32_t>> & out );
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
CCPNobody
reviewed
Sep 11, 2026
|
|
||
| EveDamageOverlayPtr EveSpaceObjectChild::EnsurePartDamageOverlay( PartTag ) | ||
| { | ||
| CCP_ASSERT( false ); |
Member
Author
There was a problem hiding this comment.
Kind of. This "ensure" function is basically "get or create". So it should never return null.
What would the proper default implementation be?
- Returning a nullptr would violate the premise, that this function is never returning null.
- Creating new objects, just to be able to return something that is not null, seems like an even worse choice. Not only because of the unnecessary allocation, but also because you would expect GetPartDamageOverlay to not return null when you call it later on with that partTag.
Which is why I chose asserting that the function has a proper implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://fenriscreations.atlassian.net/browse/PLAT-11995
Integration of modular ship base system and impact overlays.
Fixes damage displayed on modular ships, as well as shield effect and debris particle effects.
Generalizes damage overlay functions from EveChildMesh to EveSpaceObjectChild, and provides implementations for EveChildInstancedMeshes.
Akin to EveChildMesh, makes parts in EveChildInstancedMeshes own their locators.
Added python exposed function for explosion and benchmark scripts to get transformed locators.
In conjunction with https://p4swarm.ccp.ad.local/reviews/3505580