fix ResizeObserver not working in a popout#519
Open
muerwre wants to merge 1 commit intocaplin:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when window is opened in a popout, and the main window is unfocused, layout recalculations doesn't happen (or they heavily throttled with up to 1 minute delay).
A fix to that would be to use ResizeObserver of current window (just creating
new ResizeObserver(...)uses one from parent window and executes callbacks in main window context for some reason).Also, window resize event is throttled too, so, I've added observation on document body of popout as a fallback.
Not a final and clean solution, I guess, but somehow it works on my setup in a complex app with nested Layouts.