Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion apis/data-service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@
<flattenMode>oss</flattenMode>
</configuration>
</plugin>
<plugin>
<artifactId>maven-clean-plugin</artifactId>
<version>3.5.0</version>
<configuration>
<filesets>
<fileset>
<directory>src/main/resources/cds/capire/xflights-data</directory>
<excludes>
<exclude>index.cds</exclude>
</excludes>
</fileset>
</filesets>
</configuration>
</plugin>
<plugin>
<groupId>com.sap.cds</groupId>
<artifactId>cds-maven-plugin</artifactId>
Expand Down Expand Up @@ -66,7 +80,7 @@
</goals>
<configuration>
<commands>
<command>export srv/data-service.cds -4 mvn -a cdl -2 ./apis/data-service/src/main/resources/cds/capire/xflights-data</command>
<command>export srv/data-service.cds --data --texts --as cdl -4 mvn -2 ./apis/data-service/src/main/resources/cds/capire/xflights-data</command>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing: if we use -- parameters at one place maybe we can use them consitently:

Would this work, too?

export srv/data-service.cds --data --texts --as cdl --for mvn --to

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I also thought about that, but that makes the command even longer :(
I actually wanted to use short names everywhere but -d seems to be an alias for both --debug AND --data, leading to the command only writing a debug help output :(
I guess this needs to be fixed in @sap/cds-dk.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. 🥲

</commands>
</configuration>
</execution>
Expand Down