Claude/run npm clone w9 qo1#4
Merged
oblomov-dev merged 6 commits intomainfrom Apr 24, 2026
Merged
Conversation
- Switch sap.app.i18n to object form with supportedLocales/fallbackLocale - Remove empty dataSources placeholder - Remove unused default JSON model and data.json - Add sap.fiori section (archeType transactional) - Enable handleValidation - Drop redundant async flags (implied by IAsyncContentCreation) https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
Folder and project-level names (package.json, ui5.yaml metadata.name) are updated. The internal UI5 namespace stays "app2" because the sap.app.id schema does not allow hyphens. https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
Renames the folder, project names and the UI5 namespace used in sap.app.id, resource-roots, module paths, controller/view names and the i18n bundle. https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
Add lint:ui5 (ui5lint) and lint:eslint scripts and make the top-level lint task run both. The @ui5/linter dependency was already declared. https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
Runs ESLint and @ui5/linter on pull_request events. Also allows manual triggering via workflow_dispatch. https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
data-sap-ui-async and data-sap-ui-compat-version have no effect in OpenUI5 2.x (async is the only mode and the compatibility layer is gone), so they are dropped. https://claude.ai/code/session_01A68Lz4NQgu355krGCPNnD8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.