Skip to content

Use workflows of https://github.com/cap-java/.github - #118

Open
lisajulia wants to merge 2 commits into
mainfrom
chore-workflows
Open

Use workflows of https://github.com/cap-java/.github#118
lisajulia wants to merge 2 commits into
mainfrom
chore-workflows

Conversation

@lisajulia

Copy link
Copy Markdown
Contributor

No description provided.

@lisajulia

Copy link
Copy Markdown
Contributor Author

@markusbucher: Can you have a look at this? Thanks!

@markusbucher markusbucher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall direction is good — centralizing CI actions, pinning SHAs, adding least-privilege permissions: blocks, and adding security scans to PRs are all the right moves. A few issues need to be resolved before this is safe to merge.

Comment thread .github/workflows/main-build-and-deploy-oss.yml
Comment thread .github/workflows/main-build-and-deploy-oss.yml
Comment thread .github/workflows/main-build-and-deploy-oss.yml
Comment thread .github/workflows/main-build-and-deploy-oss.yml
Comment thread .github/workflows/main-build-and-deploy-oss.yml
Comment thread .github/workflows/main-build.yml
Comment thread .github/workflows/pull-request-build.yml

@markusbucher markusbucher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, some corrections of AI assumptions were needed. Findings seem to be accurate now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants