Add architecture files for cds-feature-ai-core, cds-feature-recommendations - #111
Add architecture files for cds-feature-ai-core, cds-feature-recommendations#111lisajulia wants to merge 9 commits into
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Add Architecture Documents and Improve READMEsDocumentation📚 Added detailed architecture documentation for Changes
PR Bot InformationVersion:
|
There was a problem hiding this comment.
Two issues found: a broken relative link in cds-feature-recommendations/docs/architecture.md that points to a non-existent path, and a double-article typo ("an the") in cds-starter-ai/README.md. Both are straightforward to fix with the suggested corrections.
PR Bot Information
Version: 1.26.14
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
7f159260-792f-11f1-90a0-17a3f9ca90e6
138c964 to
a355097
Compare
a355097 to
415193e
Compare
|
In any case: I suggest to wait for @agoerler's review of this before merging 👨💻 |
Co-authored-by: Marvin L <marvin.lindner@sap.com> Signed-off-by: Lisa Julia Nebel <lisajuliafog@yahoo.de>
|
@Schmarvinius: Thanks! |
agoerler
left a comment
There was a problem hiding this comment.
Hi @lisajulia, this is very helpful :-). I wish I had this overview right from the start.
Please consider to add a link from the readme files to the architecture files.
Intermediate feedback. I only have started to look at the CoreAI-part ...
agoerler
left a comment
There was a problem hiding this comment.
Hi @lisajulia,
the document for AI Core is very low level. I think the document would benefit a lot if you'd give more context information and describe architecture decisions on a higher level.
8e14976 to
8fc3611
Compare
8fc3611 to
23159cf
Compare
23159cf to
a4a982b
Compare
e5dd0cc to
296cad7
Compare
296cad7 to
e812586
Compare
Uh oh!
There was an error while loading. Please reload this page.