Skip to content
This repository was archived by the owner on Jun 5, 2023. It is now read-only.

Conversation

@DaveOrDead
Copy link
Contributor

Fixes #106 also included clearfix as that hasn't been used at all since introducing flexbox

@chris-pearce

* The "h" stands for "helper".
*
* ----------------------------------------------------------------------------
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still references in the text above to the classes you've removed.

*/

.h-clear-fix {
@include clear-fix(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the mixin also.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also be able to remove this mixin also (and its comments)?

@mixin text-osx-font-smoothing($apply-important-keyword: false) {
    $important-keyword: if($apply-important-keyword, ' !important', '');

    -moz-osx-font-smoothing: grayscale#{$important-keyword};
    -webkit-font-smoothing: antialiased#{$important-keyword};
}

@include apply-at-breakpoints('.h-text-align-right', $shell-helper-define-text-align-right-breakpoints) {
text-align: right !important;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the related settings also.

@chris-pearce
Copy link
Contributor

@DaveOrDead please make sure you've followed the applicable steps here: https://github.com/campaignmonitor/shell/blob/master/CONTRIBUTING.md#steps-for-contributing-code-to-shell.

Also once this gets merged to master we have to bump the version, publish to NPM, and create a new Git tag. As these changes are breaking we'll be onto 3.0.0. Currently all of this is manual and needs to be done when merged to master, leave it with me and I'll take care of it (including merging this to master).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Look at removing all 1 line Helpers

3 participants