-
Notifications
You must be signed in to change notification settings - Fork 2
Prepare r1.1 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prepare r1.1 #73
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
|
@caubut-charter Thanks for opening this PR for review. For a release-candidate version within the Fall25 meta-release cycle it is quite late and not yet complete. There are no test definitions for the API(s) and they are mandatory for a release-candidate. There are also various issues which would need to be resolved. Alternative could be to declare the version within the release as 0.1.0-alpha.1 (as currently in the main branch) and continue the release-cycle outside of the meta-release. Some formal points:
|
|
Beyond the formal points above I have run two reviews with help of Claude instead of a manual review: technically for compliance with the Design Guidelines of CAMARA and a design review against the recommendation within the CAMARA Design Guide. The issues found in the first (technical) are quite easy to address (and should be done even for an alpha version release):
Further issues which are overlapping with the design review:
Please consider for the custom error codes:
Here is the full report: nam-camara-compliance-review.md -- please consider that not all points might be relevant for your API (e.g. pagination if there only a few instances expected). One additional question from my side: it is intentional that only the endpoints for /isolated-networks are mandatory to be implemented while all other features (service sites, devices, reboot requests) are optional extensions (as they have 501 as possible response)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just seen that at least one of the comments which I wrote got lost (maybe I haven't submitted it before closing the browser).
To be very clear: the current state of the API is from perspective of Release Management NOT ready for pre-release with a release-candidate version. The issues raised within #73 (comment) must be resolved before (including at least basic test definitions), also the first set of issues raised in #73 (comment)
The alternative is to pre-release an alpha version (without test definitions). But also for that several of the points should be addressed before release creation.
|
And here is - just for your later consideration - the result of the automated design review (I removed some points which I didn't consider as relevant): nam-camara-design-review.md The summary:
|
|
Given the above review comments, Release Management recommends doing an alpha release outside the Fall25 meta-release, and prepare the public release for Spring26. this means
|
|
@hdamker @tanjadegroot thanks for the review and feedback. We have our next meeting on Friday and will review the feedback and respond with a plan to address the feedback after we discuss there. |
|
@camaraproject/network-access-management_codeowners I suggest that this PR is outdated and should be closed |
What type of PR is this?
What this PR does / why we need it:
Release.
Which issue(s) this PR fixes:
Fixes #72 , #34
Does this PR introduce a breaking change?
Special notes for reviewers:
Changelog input
Additional documentation