Merged
Conversation
CAMOBAP
reviewed
Mar 6, 2026
Collaborator
CAMOBAP
left a comment
CAMOBAP
left a comment
There was a problem hiding this comment.
Looks good!
Minor things
Collaborator
There was a problem hiding this comment.
Minor: should be dropped, please use bun
Collaborator
There was a problem hiding this comment.
Comment on lines
+5
to
+6
| #ifdef __APPLE__ | ||
| #ifdef __OBJC__ |
Collaborator
There was a problem hiding this comment.
Suggested change
| #ifdef __APPLE__ | |
| #ifdef __OBJC__ | |
| #if defined(__APPLE__) && defined(__OBJC__) |
And we can avoid double definition of fallback to fprintf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved from ios/ to shared cxx/