Open
Conversation
|
ba6b3f5 to
e2d3c99
Compare
e2d3c99 to
17f26ca
Compare
17f26ca to
cc28ded
Compare
cc28ded to
3f63bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies remote/cloud device guidance after the remote DevTools tunnel work landed on
mainin #487. This PR is now narrower: it keeps the new remote Android companion tunnel path, but prevents agents from trying remote iOS React DevTools while the current cloud service rejects that device-port route.Details:
boot,ensure-simulator,alert, andkeyboard, using remote/cloud device wording instead of making agents reason about bridge internals.help workflow,help remote, andhelp react-devtoolswith remote profile guidance for device lifecycle, runner-backed helper fallbacks, and React DevTools tunnel behavior.Touched files: 7. Scope includes wording cleanup plus the small React DevTools remote iOS fail-fast guard so CLI behavior matches verified cloud behavior.
Validation
pnpm formatpnpm exec vitest run src/__tests__/cli-react-devtools.test.ts src/utils/__tests__/args.test.tspnpm check:quickpnpm buildpnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case remote-cloud-avoids-local-device-setuppnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case remote-ios-cloud-react-devtools-unavailable