Skip to content

fix(ios): keep pages out of the safe area again #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R4M80MrX wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

fix(ios): keep pages out of the safe area again #1140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ios/PagerViewProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,14 @@ import UIKit
return
}

// The hosting view must not carry a safe area: `PagerView`'s `GeometryReader`
// is measured inside it, and every page is framed to that measurement, so the
// pages end up inset by the safe area while React Native's own layout still
// has them at full size. `propagateSafeArea()` on `PageChildViewController`
// is what gives child UIKit views their insets back; the two are independent.
let hostingController = UIHostingController(
rootView: PagerView(props: props, delegate: delegate)
rootView: PagerView(props: props, delegate: delegate),
ignoreSafeArea: true
)
self.hostingController = hostingController

Expand Down