feat: cache iOS runner artifacts during prepare#688
Open
thymikee wants to merge 3 commits into
Open
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
codex/ios-runner-prepare-cache-ci
branch
3 times, most recently
from
902f3c7 to
6e6a593
Compare
thymikee
force-pushed
the
codex/ios-runner-prepare-cache-ci
branch
from
6e6a593 to
73713ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepare ios-runnernow owns iOS runner artifact restore/build/health behavior: cache hits launch from the restored.xctestrun, misses build through prepare, and bad restored artifacts are cleaned and rebuilt once.The prepare path is now a dedicated
prepareIosRunnerAPI instead of prepare-only flags on generic runner commands, so normal runner execution does not carry cache recovery or diagnostics assumptions. Request-scoped provider tests still route prepare health through the provider seam.The iOS CI and nightly iOS replay workflows now dogfood this path by restoring/saving the runner cache without prebuilding on cache miss, then running
prepare ios-runner --timeout 300000 --jsonas the single build-or-health gate.Added unit stress coverage for exact cache hits, bad-artifact marking, cleanup, rebuild, timeout propagation, metadata parity, prepare timeout option plumbing, and runner-client prepare recovery/double-failure orchestration.
Touched files: 14. Scope expanded from runner runtime to CI workflow/action wiring so this repo uses the new prepare-owned cache path.
Validation
pnpm check:quickpassed.pnpm check:fallow --base origin/mainpassed.Targeted runner/prepare tests passed:
pnpm exec vitest run src/platforms/ios/__tests__/runner-client.test.ts src/platforms/ios/__tests__/runner-session.test.ts src/platforms/ios/__tests__/runner-xctestrun.test.ts src/daemon/handlers/__tests__/session.test.ts --project unit.Recovery-focused runner tests passed:
pnpm exec vitest run src/platforms/ios/__tests__/runner-command-retry.test.ts src/platforms/ios/__tests__/runner-xctestrun.test.ts src/daemon/handlers/__tests__/session.test.ts --project unit.Provider integration passed:
pnpm test:integration:provider.Coverage passed outside the sandbox:
pnpm test:coveragewith 2106 passed tests and 1 skipped.Smoke validation passed separately:
pnpm test:smoke.pnpm check:unitwas attempted after the simplification but local full-suite runs hit unrelated 5s Android/iOS timing flakes; each failed test passed when rerun in isolation. CI has restarted on this PR.