Repository navigation
test(ios): speed up fixtures and run native regressions nightly - #3824
Conversation
Size Report
Startup median (7 runs, lower is better):
|
|
The PR is ready at 431a94c. The code looks good, and I found nothing that needs a change. Not blocking: the guardedCommands table in RunnerTests+CommandDispatchTests.swift has two identical drag entries ("standard drag" and "drag"), so you can drop one. The merged test also reports every failure only if continueAfterFailure is true, but the named assertions already identify the failing case, so no change is needed. Take or leave both. Smoke Tests is still running, and I could not attribute any failure yet. The diff touches only the iOS runner XCTest sources, so it overlaps only the native iOS unit and regression route. I did not run the XCTest suite, so I have not confirmed that the merged tests pass or that the timing gain is real. I also did not confirm that the merged banner test fails when the interruption opt-out is removed, though the new stub assertion should catch that. There are no conflicts. Smoke Tests must finish green, including the native iOS runner unit tests, before this can merge. |
431a94c to
14f32fb
Compare
|
Addressed the optional duplicate drag row from the review. The retained drag assertion still catches the production mutant that admits non-tap commands to the cached activation bypass: one selected method fails on drag, scroll and sequences. The restored three-method control passes. The complete profiling evidence records 118 matched methods, the 331-method nightly complement, the isolated fixture timing comparison, five detected mutants and Xcode 27 checks. Full native fault coverage now runs nightly; PRs retain host tests, four source-derived iOS branch checks and public CLI E2E. The optional-probe completion oracle moves with its test. Final local receipt at |
|
Android at The same command, assertion and diagnostic failed on unchanged main Tracked in #3831 with ownership, both run links and the missing first-capture trace evidence. No timeout increase, skip or retry was applied. Android remains failed, and this PR is not merge-ready. Coverage and Integration passed at the actual head; Apple is still running. Ready-for-review status is preserved as requested. |
|
The earlier clean review of 431a94c still holds at 14f32fb, and I found nothing in the diff that needs a change. The one failing check is Smoke Tests, in the step "Run Android smoke checks": waiting for "Automation lab" fails with wait_capture_stalled. This looks unrelated, because the diff touches no packages/ or src/ files and the Android capture and wait route does not overlap it; it also matches #3831, which you reproduced on unchanged main. I know of no conflicts. Before merge, re-run Smoke Tests or accept the Android failure as known flake #3831. The rewritten xctest-nightly.yml cannot run on this PR, and your evidence doc says the 449 nightly identifiers ran locally across two invocations, not as a dispatched CI run. I did not re-run those, the selection script or the Swift tests, and I did not check that each claimed mutation turns the new tap-count tests red. The lane counts (338 host, 4 PR, 449 nightly) come from your doc. |
|
Summary
Validation
14f32fb218ac9e5608012bf6a5805652dc61f7fc: affected gate passed,exactCommit=true,checkoutChanged=false(36 passed, 25 skipped, two deduplicated).19573d42b0/7bb347f771.14f32fb: Coverage and Integration passed. Android is blocked by #3831, a capture-stall signature also observed on main; cause unresolved, no infrastructure retry. Apple passed in 23m49s; iOS platform checks took 2m55s (four tests, 0.8s bodies). Native fault regressions now run after merge nightly.