Repository navigation
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
2f64746 to
deae993
Compare
aa05a74 to
2e08f8f
Compare
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
deae993 to
447eb9e
Compare
2e08f8f to
8566cee
Compare
447eb9e to
9096044
Compare
8566cee to
5645905
Compare
|
The code has one problem to fix before merge, and CI is green: 18 checks, 0 failing at 5645905. There are no conflicts.
plugins list leaves out the daemon inventory, even while a daemon serves that state dir. The rule: one owner in daemon-contracts parses daemon.json, and every reader uses it. Please move readDaemonInfo and its field readers into daemon-contracts next to readRegistration, or extend readRegistration to return the parsed record. Then build readDaemonStatus from that record and its registered, absent or unreadable status, delete readRecord and isTransport, and report "unreadable" instead of running: false. A test with an unreadable daemon.json should show that case.
Could Not blocking, take or leave: plugins.md does not yet mention the daemon inventory that Of the open inline threads, none still apply. All five are fixed at 5645905, so please resolve them: --clean only on stop, plugins flags per action, null start time, start-time JSDoc and plugins usage text. No test here proves that a real daemon writes Before merge, one |
9096044 to
105f415
Compare
5645905 to
8e5814d
Compare
|
Thanks. Fixed in 8e5814d (stack top 7f449c5 passed
On the docs sentence: |
`daemon status [--json]` reads the daemon record without contacting the daemon and reports every provider it registered, with the reason any plugin failed. `plugins list --json` reports the running daemon's inventory next to the store selections. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
105f415 to
bd57cd7
Compare
8e5814d to
e886ff7
Compare
|
The PR is ready at e886ff7. The earlier findings from #3768 (comment) are fixed, and I have no new blocking findings. Not blocking: The five open cubic-dev-ai threads are fixed at this head, so you can resolve them: the daemon usage and flags (#3768 (comment)), the plugins flags (#3768 (comment)), the unreadable start-time case (#3768 (comment)), the All 15 checks pass at e886ff7, and there are no conflicts. This was a read-only review: I did not rerun |
Summary
Part 2 of 4 of #3755 (umbrella #3747), stacked on #3767. Blocked by #3748: do not merge before it.
agent-device daemon status [--state-dir <path>] [--json]readsdaemon.jsonwithout contacting the daemon and lists every provider it registered (builtin/store/embedder,active/failed, typederror.reason). A record whose pid/start time no longer names a live process reportsrunning: false.plugins list --jsonstill works without a daemon (it lists store selections), and when a daemon runs for the same--state-dirit also returns that daemon's inventory underdaemon.daemonandpluginsschema, usage and help updated;daemonstays out of MCP (mcpExposed: false).Not in this PR: the failed inventory entry inside the
provider-not-registerederror. #3748 owns that error, so I'll add the entry after rebasing onto it.9 files.
Validation
pnpm check:affected --run --head 495046c784(the stack top, which contains this layer): passed (exactCommit). CI owns integration, coverage and device lanes.🤖 Generated with Claude Code