Repository navigation
feat(react-devtools): drill into the saved React profile by component and commit - #3618
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Size Report
Startup median (7 runs, lower is better):
|
|
The drill-down code in b11b5ad looks good, and I found nothing that blocks it. CI is still running: 18 of 21 checks are queued or in progress and none has failed. No conflicts. Two of the open Cubic threads still need a fix, and then the queued checks need to go green before merge. Not blocking: On the open threads: the commit --json thread still applies, because I did not run the tests. The new tests call subcommands that do not exist on the base, so they would fail there. The simulator and Android runs are described in the PR body only. The drill-downs read just a local file, so I did not need live device evidence. |
|
b11b5ad to
546beae
Compare
546beae to
ef6f1e5
Compare
ef6f1e5 to
d627d11
Compare
d627d11 to
e82d0ab
Compare
e82d0ab to
5412067
Compare
|
At
Tests cover each fix. |
Summary
Adds drill-down views over the profile that
react-devtools profile stop(#3613) saves for the session:stopnow ends with aMore:line naming these commands. Tables say how many rows they omit.reporttakes a component name andcommittakes a whole index (6or#6). A malformed saved profile fails with a hint to record a new one. Touches 9 files (378 lines).Validation
At
54120679f8,check:affected --runandcheck:production-exportspass.Live on Android RN 0.88-rc, on this build, after the
memo-defeatedscenario:profile report ContactRowprinted its causes, the changed prop kinds, and "its costliest commits (self time of commit duration): #0 136ms of 170ms, …".On the RN 0.83 iOS simulator,
profile report ProductTileprinted both of its findings.