You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add request-local Android ADB provider and host transport support for managed lease private server ports.
Add the exact managed lease environment reachability adapter for the iOS simulator set and Android ADB port.
Add adversarial and fake-ADB tests proving transport isolation without mutating process environment.
This PR is the contained-transport foundation only. It deliberately does not register managed owners, acquire allocator claims, or wire a Host/Simlock granted lease into the exact request binding. The current managed-owner boundary fails closed until that Host integration exists, as required by ADR 0021.
Validation
pnpm check:affected --run passed on the exact head.
Focused managed reachability and Android transport suite: 45 tests passed.
Android package suite: 626 tests passed.
Apple simulator and inventory suite: 61 tests passed.
Apple XCTest suite: 103 tests passed.
Planted-red proof: reverting the Android transport implementation made 8 new tests fail.
Live Simlock-managed device evidence was unavailable locally: no active managed lease or private endpoint existed, and no device was mutated.
Follow-up
Host/Simlock integration must pass the granted lease into the exact managed runtime binding, wrap the admitted command in reachability.run, and add routed Android inventory/operation plus iOS simulator-set proof. This PR does not claim that production managed commands are wired yet.
Review at exact head f9ee5d9 is blocked. P1: createManagedLeaseReachability is only referenced by its new test; no granted lease, managed runtime binding, or request route imports it. Therefore neither the iOS simulator-set path nor Android private-ADB-port scope can affect a real managed command, and the fake-ADB tests remain green even if production can never reach the adapter. Wire it at the single granted-lease → exact managed runtime-binding boundary and add a routed regression from a granted lease through a representative Android operation/inventory proving the private port (and iOS simulator-set path), or explicitly reframe this as unused foundation rather than a routing feature. The PR has ~321 net production lines and +1.6 kB unpacked, below the escalation thresholds; all completed checks pass, iOS Smoke is still pending, and live managed-lease evidence remains unavailable.
thymikee
changed the title
feat: route managed leases through contained transports
feat(runtime): add contained transports for managed leases
Sep 5, 2026
Addressed the P1 by narrowing this PR scope. The title/body now describe the contained transport foundation, not production managed-command routing. The current tree intentionally has no Host/Simlock grant route or production managed-owner registration; ADR 0021 and the existing exact-owner refusal path make that integration a separate follow-up. The reachability adapter remains the typed seam that follow-up must use at the granted-lease → exact managed binding boundary, with routed Android inventory/operation and iOS simulator-set proof. Current head f9ee5d9 is unchanged and all GitHub checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the contained-transport foundation only. It deliberately does not register managed owners, acquire allocator claims, or wire a Host/Simlock granted lease into the exact request binding. The current managed-owner boundary fails closed until that Host integration exists, as required by ADR 0021.
Validation
pnpm check:affected --runpassed on the exact head.Follow-up
Host/Simlock integration must pass the granted lease into the exact managed runtime binding, wrap the admitted command in
reachability.run, and add routed Android inventory/operation plus iOS simulator-set proof. This PR does not claim that production managed commands are wired yet.