Repository navigation
Await the completed NOTIFY task in BlindTransferTests - #26
Merged
Merged
Conversation
xUnit1031 flagged .Result on _notifyAnswered.Task. The task has already completed at that point, so nothing could deadlock, but it was the only new build warning since v0.1.2. Await it instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xUnit1031 flagged
_notifyAnswered.Task.Resultin the test added by #25. The task has already completed at that point (the preceding assertion waits for it), so nothing could deadlock, but it is the only new build warning since v0.1.2. Build warnings go back to the 17 known ones (CS0067, CS8618, NU1903). Test-only change; the transfer tests pass.Release prep for v0.1.4.
🤖 Generated with Claude Code