fix: V2 API returns "Booking limits must be in ascending order" due to unfiltered disabled key in interval limits transformer

[muhammadusman586]

What does this PR do?

Fixes a bug where updating an event type via the V2 API fails with "Booking limits must be in ascending order" when bookingLimitsCount includes the disabled property from the BaseBookingLimitsCount_2024_06_14 DTO.

Root Cause

transformIntervalLimitsApiToInternal() in interval-limits.ts iterates all Object.entries() of the input without filtering. The BaseBookingLimitsCount_2024_06_14 class has a disabled?: boolean = false default property. Since BookingLimitsEnum_2024_06_14 only maps day, week, month, year — the disabled key has no mapping, producing res[undefined] = false.

This corrupted object (e.g. { PER_DAY: 5, undefined: false }) is then passed to validateIntervalLimitOrder() in the TRPC update handler, which fails because "undefined" is not a recognized interval limit key.

Flow:
V2 API Controller → InputEventTypesService.transformInputUpdateEventType() → transformIntervalLimitsApiToInternal({ day: 5, disabled: false }) → produces { PER_DAY: 5, undefined: false } ← BUG → validateIntervalLimitOrder() returns false → TRPCError: "Booking limits must be in ascending order"

Related Issue

#27988

Changes

apps/api/v2/.../transformers/api-to-internal/interval-limits.ts

• Added guard clause to skip keys not present in BookingLimitsEnum_2024_06_14
• Changed .map() → .forEach() since the return value is unused

apps/api/v2/.../transformers/api-to-internal/api-to-internal.spec.ts

• Added test: disabled: false with valid counts → only valid limit keys produced (no undefined key)
• Added test: disabled: true → returns empty object {}

---

[CLAassistant]

All committers have signed the CLA.

[cubic-dev-ai]

No issues found across 2 files

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.