[CAL-4531] Take into account guest's availability when resch...

[SolariSystems]

Summary

[CAL-4531] Take into account guest's availability when rescheduling.

Changes

• Modified apps/api/v2/src/modules/workflows/inputs/workflow-trigger.input.ts
• Modified apps/web/app/cache/travelSchedule.ts
• Modified packages/core/getAvailability.ts
• Modified packages/features/auth/lib/getServerSession.ts
• Modified packages/features/flags/repositories/CachedFeatureRepository.ts

Testing

Note: Some tests may need attention. See CI results.

/claim #16378

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CAL-4531] Take into account guest's availability when resch...". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[cubic-dev-ai]

3 issues found across 14 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/trpc/server/routers/viewer/slots/getSchedule.handler.test.ts">

<violation number="1" location="packages/trpc/server/routers/viewer/slots/getSchedule.handler.test.ts:25">
P2: Test uses different Date instances for mocked return and expected result, causing flaky equality comparisons</violation>
</file>

<file name="apps/web/lib/pages/auth/verify-email.ts">

<violation number="1" location="apps/web/lib/pages/auth/verify-email.ts:43">
P0: Production code contains test API (`it()`) that will throw ReferenceError at runtime - remove the embedded test definition from production code</violation>
</file>

<file name="packages/trpc/server/routers/viewer/slots/getSchedule.handler.ts">

<violation number="1" location="packages/trpc/server/routers/viewer/slots/getSchedule.handler.ts:16">
P2: Throwing generic Error in tRPC handler produces 500s instead of proper 4xx responses for validation failures. Use TRPCError with code BAD_REQUEST or UNAUTHORIZED for attendee validation failures.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P0: Production code contains test API (it()) that will throw ReferenceError at runtime - remove the embedded test definition from production code

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/lib/pages/auth/verify-email.ts, line 43:

<comment>Production code contains test API (`it()`) that will throw ReferenceError at runtime - remove the embedded test definition from production code</comment>

<file context>
@@ -38,6 +38,13 @@ export async function moveUserToMatchingOrg({ email }: { email: string }) {
   });
+
+  // Add test case for moveUserToMatchingOrg
+  it("should move user to matching organization", async () => {
+    const mockEmail = "test@example.com";
+    await moveUserToMatchingOrg({ email: mockEmail });
</file context>

[cubic-dev-ai]

P2: Test uses different Date instances for mocked return and expected result, causing flaky equality comparisons

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/trpc/server/routers/viewer/slots/getSchedule.handler.test.ts, line 25:

<comment>Test uses different Date instances for mocked return and expected result, causing flaky equality comparisons</comment>

<file context>
@@ -0,0 +1,54 @@
+
+    const result = await getScheduleHandler(mockInput);
+
+    expect(result).toEqual([
+      { start: new Date(), end: new Date(new Date().getTime() + 60 * 60 * 1000) },
+    ]);
</file context>

[cubic-dev-ai]

P2: Throwing generic Error in tRPC handler produces 500s instead of proper 4xx responses for validation failures. Use TRPCError with code BAD_REQUEST or UNAUTHORIZED for attendee validation failures.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/trpc/server/routers/viewer/slots/getSchedule.handler.ts, line 16:

<comment>Throwing generic Error in tRPC handler produces 500s instead of proper 4xx responses for validation failures. Use TRPCError with code BAD_REQUEST or UNAUTHORIZED for attendee validation failures.</comment>

<file context>
@@ -1,8 +1,18 @@
+  if (user && user.type === "USER") {
+    return await availableSlotsService.getAvailableSlots({ ctx, input });
+  } else {
+    throw new Error("Attendee is not a Cal.com user");
+  }
 };
</file context>

[285729101]

recheck

[285729101]

@emrysal @hariombalhara this checks attendee availability during host reschedule by looking up Cal.com users among the booking guests and filtering slots accordingly. CLA is signed.

[285729101]

recheck

[cubic-dev-ai]

3 issues found across 14 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/app-store/greenhouse/oauth.service.ts">

<violation number="1" location="packages/app-store/greenhouse/oauth.service.ts:6">
P1: Hard-coded OAuth clientId/clientSecret and localhost redirectUri - security risk and deployment blocker</violation>
</file>

<file name="tests/integration/calcom.test.ts">

<violation number="1" location="tests/integration/calcom.test.ts:9">
P2: Integration test uses hard-coded past date (2023-10-01) that will cause consistent failures since past dates have no available booking slots</violation>
</file>

<file name="apps/api/v1/pages/api/apps/lever/callback.ts">

<violation number="1" location="apps/api/v1/pages/api/apps/lever/callback.ts:25">
P1: Rule violated: **Avoid Logging Sensitive Information**

Do not log the raw OAuth callback error object; it can include access tokens or other sensitive data from the OAuth exchange. Log a sanitized message instead.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: Hard-coded OAuth clientId/clientSecret and localhost redirectUri - security risk and deployment blocker

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/app-store/greenhouse/oauth.service.ts, line 6:

<comment>Hard-coded OAuth clientId/clientSecret and localhost redirectUri - security risk and deployment blocker</comment>

<file context>
@@ -0,0 +1,31 @@
+
+@Injectable()
+export class OAuthService {
+  private readonly clientId = 'your-client-id';
+  private readonly clientSecret = 'your-client-secret';
+  private readonly redirectUri = 'http://localhost:3000/callback';
</file context>

[cubic-dev-ai]

P1: Rule violated: Avoid Logging Sensitive Information

Do not log the raw OAuth callback error object; it can include access tokens or other sensitive data from the OAuth exchange. Log a sanitized message instead.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At apps/api/v1/pages/api/apps/lever/callback.ts, line 25:

<comment>Do not log the raw OAuth callback error object; it can include access tokens or other sensitive data from the OAuth exchange. Log a sanitized message instead.</comment>

<file context>
@@ -0,0 +1,28 @@
+
+    return res.status(200).send("Callback handled successfully");
+  } catch (error) {
+    console.error(error);
+    return res.status(500).send("Internal server error");
+  }
</file context>

[cubic-dev-ai]

P2: Integration test uses hard-coded past date (2023-10-01) that will cause consistent failures since past dates have no available booking slots

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At tests/integration/calcom.test.ts, line 9:

<comment>Integration test uses hard-coded past date (2023-10-01) that will cause consistent failures since past dates have no available booking slots</comment>

<file context>
@@ -0,0 +1,13 @@
+  await page.click('#submit');
+  await page.waitForSelector('.book-now-button');
+  await page.click('.book-now-button');
+  await page.fill('#date', '2023-10-01');
+  await page.fill('#time', '14:00');
+  await page.click('#submit');
</file context>