Skip to content

[CAL-1425] Add Exchange 2019 option (mapped to EWS 2016)#28008

Open
MrLawrenceKwan wants to merge 1 commit intocalcom:mainfrom
MrLawrenceKwan:fix/8123-exchange-2019-ews-compat
Open

[CAL-1425] Add Exchange 2019 option (mapped to EWS 2016)#28008
MrLawrenceKwan wants to merge 1 commit intocalcom:mainfrom
MrLawrenceKwan:fix/8123-exchange-2019-ews-compat

Conversation

@MrLawrenceKwan
Copy link

Summary

Fixes part of #8123 by adding explicit Exchange 2019 support in the Exchange setup flow while keeping EWS compatibility.

Changes

  • Add Exchange2019 to ExchangeVersion
  • Add 2019 option in setup selector
  • Map Exchange 2019 to Exchange 2016 in ExchangeService creation (same EWS schema)

Validation

  • Ran: yarn lint --filter=@calcom/exchangecalendar --filter=@calcom/web
  • Command completed; existing repo-wide lint warnings are unrelated.

/claim #8123

Bounty reference: Algora $40 on #8123

@MrLawrenceKwan MrLawrenceKwan requested a review from a team as a code owner February 17, 2026 15:22
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 17, 2026
@github-actions
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CAL-1425] Add Exchange 2019 option (mapped to EWS 2016)". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/web/components/apps/exchangecalendar/Setup.tsx">

<violation number="1" location="apps/web/components/apps/exchangecalendar/Setup.tsx:64">
P2: Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

{ value: ExchangeVersion.Exchange2013_SP1, label: t("exchange_version_2013_SP1") },
{ value: ExchangeVersion.Exchange2015, label: t("exchange_version_2015") },
{ value: ExchangeVersion.Exchange2016, label: t("exchange_version_2016") },
{ value: ExchangeVersion.Exchange2019, label: "2019" },
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/components/apps/exchangecalendar/Setup.tsx, line 64:

<comment>Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead</comment>

<file context>
@@ -61,6 +61,7 @@ export default function ExchangeSetup() {
     { value: ExchangeVersion.Exchange2013_SP1, label: t("exchange_version_2013_SP1") },
     { value: ExchangeVersion.Exchange2015, label: t("exchange_version_2015") },
     { value: ExchangeVersion.Exchange2016, label: t("exchange_version_2016") },
+    { value: ExchangeVersion.Exchange2019, label: "2019" },
   ];
 
</file context>
Suggested change
{ value: ExchangeVersion.Exchange2019, label: "2019" },
{ value: ExchangeVersion.Exchange2019, label: t("exchange_version_2019") },
Fix with Cubic

@romitg2
Copy link
Member

romitg2 commented Feb 17, 2026

@MrLawrenceKwan could you please provide before/after visual demo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim community Created by Linear-GitHub Sync size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments