[CAL-1425] Add Exchange 2019 option (mapped to EWS 2016)#28008
Open
MrLawrenceKwan wants to merge 1 commit intocalcom:mainfrom
Open
[CAL-1425] Add Exchange 2019 option (mapped to EWS 2016)#28008MrLawrenceKwan wants to merge 1 commit intocalcom:mainfrom
MrLawrenceKwan wants to merge 1 commit intocalcom:mainfrom
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/components/apps/exchangecalendar/Setup.tsx">
<violation number="1" location="apps/web/components/apps/exchangecalendar/Setup.tsx:64">
P2: Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| { value: ExchangeVersion.Exchange2013_SP1, label: t("exchange_version_2013_SP1") }, | ||
| { value: ExchangeVersion.Exchange2015, label: t("exchange_version_2015") }, | ||
| { value: ExchangeVersion.Exchange2016, label: t("exchange_version_2016") }, | ||
| { value: ExchangeVersion.Exchange2019, label: "2019" }, |
Contributor
There was a problem hiding this comment.
P2: Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/components/apps/exchangecalendar/Setup.tsx, line 64:
<comment>Hardcoded label "2019" breaks localization consistency - use t("exchange_version_2019") instead</comment>
<file context>
@@ -61,6 +61,7 @@ export default function ExchangeSetup() {
{ value: ExchangeVersion.Exchange2013_SP1, label: t("exchange_version_2013_SP1") },
{ value: ExchangeVersion.Exchange2015, label: t("exchange_version_2015") },
{ value: ExchangeVersion.Exchange2016, label: t("exchange_version_2016") },
+ { value: ExchangeVersion.Exchange2019, label: "2019" },
];
</file context>
Suggested change
| { value: ExchangeVersion.Exchange2019, label: "2019" }, | |
| { value: ExchangeVersion.Exchange2019, label: t("exchange_version_2019") }, |
Member
|
@MrLawrenceKwan could you please provide before/after visual demo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #8123 by adding explicit Exchange 2019 support in the Exchange setup flow while keeping EWS compatibility.
Changes
Exchange2019toExchangeVersion2019option in setup selectorExchangeServicecreation (same EWS schema)Validation
yarn lint --filter=@calcom/exchangecalendar --filter=@calcom/web/claim #8123
Bounty reference: Algora $40 on #8123