fix: prevent nested <a> element in NavigationItem#27985
Open
devanshu0x wants to merge 2 commits intocalcom:mainfrom
Open
fix: prevent nested <a> element in NavigationItem#27985devanshu0x wants to merge 2 commits intocalcom:mainfrom
devanshu0x wants to merge 2 commits intocalcom:mainfrom
Conversation
Member
sahitya-chandra
left a comment
There was a problem hiding this comment.
Can you add a before and after video of the changes?
and always make sure to add these videos in your future prs, otherwise we will not be able to approve your prs.
Contributor
Author
@sahitya-chandra I have added before and after video of the fix, I will make sure to include relevant visual demos in future prs as well |
40ea5f1 to
1df7bfe
Compare
apps/web/modules/bookings/components/UnconfirmedBookingBadge.tsx
Outdated
Show resolved
Hide resolved
1df7bfe to
5278c75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
The
NavigationItemcomponent renders nested<a>elements due to an additionalLinkwrapper.Solution
Instead of using
Link, render the badge inside a non interactive<div>with an onClick handler that callsrouter.push("/bookings/unconfirmed")to preserve the intended navigation without introducing nested interactive elements.Visual Demo
Before
Before.mp4
After
After-2.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Steps to Reproduce
Expected Behavior (After Fix)