Add test case to show collation issue in MysqlAdapter::createTable()#1020
Open
ishanvyas22 wants to merge 1 commit intocakephp:4.xfrom
Open
Add test case to show collation issue in MysqlAdapter::createTable()#1020ishanvyas22 wants to merge 1 commit intocakephp:4.xfrom
ishanvyas22 wants to merge 1 commit intocakephp:4.xfrom
Conversation
When collation is set on field the createTable() generates wrong sql which leads to wrong collation on the field when table is created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When collation is set on field the
createTable()generates wrong sql which leads to wrong collation on the field when table is created. This issue is seems to be present from v4.6 where$this->getColumnSqlDefinition()changed to$dialect->columnDefinitionSql()inMysqlAdapterfile (#839). The weird part is there's no direct test case which tests thecreateMethod(), may be there's a reason for that but then this scenario should've covered.This PR adds a test case to only demonstrate the issue present. I have not applied any fix since I'm not sure which place would be the right place to fix it.