Fix docs incorrectly stating primary keys default to unsigned#1015
Merged
Fix docs incorrectly stating primary keys default to unsigned#1015
Conversation
The documentation claimed primary keys are unsigned by default, but the actual code defaults to signed. Unsigned primary keys require either passing 'signed' => false or enabling the Migrations.unsigned_primary_keys feature flag.
dereuromark
force-pushed
the
fix/docs-unsigned-primary-key-default
branch
from
ba51013 to
d6e4487
Compare
Both flags should be used together so foreign key columns match the unsigned primary keys they reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writing-migrations.rstclaimed primary keys are unsigned by default, but the code defaults to signed (seeMysqlAdapterline 275 andColumn::getUnsigned())signeddefaults totrue(notfalse)Migrations.unsigned_primary_keysfeature flag.. _feature-flags:ref label toindex.rstso the cross-reference works