Reword file-based routing terminlogy to a more intuitive 'config-base…#8294
Merged
Reword file-based routing terminlogy to a more intuitive 'config-base…#8294
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the new attribute-routing documentation to rephrase the comparison between controller attributes and routes declared outside controllers, replacing “file-based” terminology with “config-based.” It fits into the docs by trying to make the routing model descriptions feel more intuitive to readers learning CakePHP 6 attribute routing.
Changes:
- Reworded the page description and introductory guidance to use “config-based routing.”
- Renamed comparison labels and section headings from “File-based” to “Config-based.”
- Updated explanatory text and inline comments throughout the page to use the new term consistently within this document.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+14
| Attribute routing is **fully optional**. You can use config-based routing, | ||
| attribute routing, or a mix of both. Existing config-based routes continue to work |
Comment on lines
533
to
545
| @@ -541,7 +541,7 @@ connects attribute routes at the position it appears in your routes file: | |||
| // Attribute routes are connected first | |||
| $routes->connectAttributes(); | |||
|
|
|||
| // File-based routes follow | |||
| // Config-based routes follow | |||
| $routes->scope('/', callback: function (RouteBuilder $routes) { | |||
Comment on lines
+450
to
451
| This is different from config-based routing where passed parameters are matched | ||
| positionally. Named argument binding is automatic for attribute routes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewords file-based routing terminology to a more intuitive 'config-based' routing.