Repository navigation
fix(console): show skipped check-ins as unavailable - #509
Merged
Merged
Conversation
A check-in the upstream marks as skipped was painted as a green success on the account card, and a one-click check-in-all run counted it as checked. Show the existing "activity unavailable" state instead and count those accounts as failed in the summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipped(activity closed, not started, or already ended) was shown as a green success on the account card. The card already had copy for this state (checkinRecordSkipped); the transient feedback only knew success / already / error, so both a single check-in and a one-click "check in all" painted it as success.skipped, and a one-click run counts those accounts as failed in the summary instead of checked.Test plan
cd frontend && npx tsc -b --forcenpx oxlinton the two changed source filescd frontend && npm run sync(embedded assets matchfrontend/dist)go test ./...(no Go changes)skippedshows the warning state and counts as failed