Repository navigation
fix: keep check-in all from failing silently - #504
Merged
Merged
Conversation
An unusable server timezone made the check-in-all click throw before any request, with nothing shown. Fall back to the browser zone and surface the error. Stop the sidebar from polling /api/live on pages that do not render it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MST -07:00, e.g.UTC +00:00) is not a nameIntlaccepts, and the error was swallowed, so the button did nothing. An unusable zone now falls back to the browser zone, and a failure shows an error toast./api/liveon every page. It now reads the count already present in the overview summary; the live poll stays on the overview, which is the page that renders it.Test plan
IntlrejectsUTC +00:00; the fallback separates yesterday's check-in from todaycd frontend && npm run sync(tsc + vite build) passes and the embedded bundle matchesfrontend/dist/api/accounts/.../checkin/api/live; the overview still does