fix: Reject UpdateDomain requests for deprecated domains #7429
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zawadzkidiana
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
fimanishi
approved these changes
Nov 10, 2025
zawadzkidiana
force-pushed
the
fix/domain-handler-reject-deprecated
branch
from
3ed70f6 to
f67ba93
Compare
timl3136
requested changes
Dec 10, 2025
Member
timl3136
left a comment
timl3136
left a comment
There was a problem hiding this comment.
Why are we updating idl pointers here? the change in idl folder seems to be not related to your change
Contributor
Author
|
Hi Tim, you're right; I'll update this diff to only include the relevant files! |
Signed-off-by: Diana Zawadzki <dzawa@live.de>
zawadzkidiana
force-pushed
the
fix/domain-handler-reject-deprecated
branch
from
f67ba93 to
3866bf6
Compare
Contributor
Author
|
Actually, I forgot: we implemented the fix herE already: #7427. I think this PR is unnecessary. Will double check and close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation in the domain handler to reject UpdateDomain requests when the domain status is DEPRECATED.
Why?
Deprecated domains should not be modified. Previously, UpdateDomain would accept requests for deprecated domains, which could lead to:
How did you test it?
TestUpdateDomain_DeprecatedDomain_ReturnsErrorto verify deprecated domains cannot be updatedcommon/domainpackage passPotential risks
Low risk. This change only affects deprecated domains, which are not actively processing workflows. The change is defensive and prevents unintended modifications.
Normal domain operations (registered, active domains) are completely unaffected.
Release notes