Skip to content

Set of() to be nullable in ReceiptCode #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cable8mm merged 1 commit into from
Feb 21, 2025
Merged

Set of() to be nullable in ReceiptCode #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ReceiptCode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ public function nextCode(): string
/**
* Create a new instance of ReceiptCode.
*
* @param string $code ReceiptCode
* @param string|null $code ReceiptCode
* @return static Provides a new instance of ReceiptCode
*/
public static function of(string $code): self
public static function of(?string $code = null): self
{
return new self($code);
return is_null($code) ? self::make() : new self($code);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions tests/ReceiptCodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,7 @@ public function test_next_code_method()
public function test_no_code()
{
$this->assertEquals('PO-'.date('Ymd').'-0001', ReceiptCode::make()->nextCode());

$this->assertEquals('PO-'.date('Ymd').'-0001', ReceiptCode::of()->nextCode());
}
}