Repository navigation
Wait for the service worker before starting a download - #67
Merged
Merged
Conversation
The app unregisters the service worker when it starts, and the first download registers it again. register() resolves before the new service worker is activated and controls the page, so the stream request could go to the network instead. The stream was never requested and Download waited forever. This made TestDownload fail on GitHub. NewStreamHelper now waits until the service worker controls the page, and Download returns an error if the stream doesn't start within 10 seconds. The test stream hook also returns an error on a non-200 status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app unregisters the service worker when it starts, and the first download registers it again. register() resolves before the new service worker is activated and controls the page, so the stream request could go to the network instead. The stream was never requested and Download waited forever. This made TestDownload fail on GitHub.
NewStreamHelper now waits until the service worker controls the page, and Download returns an error if the stream doesn't start within 10 seconds. The test stream hook also returns an error on a non-200 status.