Skip to content

Optimize MoonBit canonical list arguments with typed borrows #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
peter-jerry-ye wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Optimize MoonBit canonical list arguments with typed borrows #1672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0ac0ed
perf(moonbit): borrow canonical list arguments
peter-jerry-ye Jul 27, 2026
5bb09f4
perf(moonbit): treat boolean lists as canonical arrays
peter-jerry-ye Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions crates/moonbit/src/ffi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
pub(crate) const EXTEND16: &str = r#"
///|
extern "wasm" fn mbt_ffi_extend16(value : Int) -> Int =
#|(func (param i32) (result i32) local.get 0 i32.extend16_s)
"#;

pub(crate) const EXTEND8: &str = r#"
///|
extern "wasm" fn mbt_ffi_extend8(value : Int) -> Int =
Expand Down Expand Up @@ -126,13 +120,27 @@ extern "wasm" fn mbt_ffi_ptr2bytes(ptr : Int, len : Int) -> FixedArray[Byte] =
#| local.get 0)
"#;

pub(crate) const BOOL_ARRAY2PTR: &str = r#"
///|
#owned(array)
extern "wasm" fn mbt_ffi_bool_array2ptr(array : FixedArray[Bool]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const UINT_ARRAY2PTR: &str = r#"
///|
#owned(array)
extern "wasm" fn mbt_ffi_uint_array2ptr(array : FixedArray[UInt]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const UINT16_ARRAY2PTR: &str = r#"
///|
#owned(array)
extern "wasm" fn mbt_ffi_uint16_array2ptr(array : FixedArray[UInt16]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const UINT64_ARRAY2PTR: &str = r#"
///|
#owned(array)
Expand All @@ -147,6 +155,13 @@ extern "wasm" fn mbt_ffi_int_array2ptr(array : FixedArray[Int]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const INT16_ARRAY2PTR: &str = r#"
///|
#owned(array)
extern "wasm" fn mbt_ffi_int16_array2ptr(array : FixedArray[Int16]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const INT64_ARRAY2PTR: &str = r#"
///|
#owned(array)
Expand All @@ -168,6 +183,15 @@ extern "wasm" fn mbt_ffi_double_array2ptr(array : FixedArray[Double]) -> Int =
#|(func (param i32) (result i32) local.get 0)
"#;

pub(crate) const PTR2BOOL_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2bool_array(ptr : Int, len : Int) -> FixedArray[Bool] =
#|(func (param i32) (param i32) (result i32)
#| local.get 0
#| local.get 1 call $moonbit.init_array8
#| local.get 0)
"#;

pub(crate) const PTR2UINT_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2uint_array(ptr : Int, len : Int) -> FixedArray[UInt] =
Expand All @@ -177,6 +201,15 @@ extern "wasm" fn mbt_ffi_ptr2uint_array(ptr : Int, len : Int) -> FixedArray[UInt
#| local.get 0)
"#;

pub(crate) const PTR2UINT16_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2uint16_array(ptr : Int, len : Int) -> FixedArray[UInt16] =
#|(func (param i32) (param i32) (result i32)
#| local.get 0
#| local.get 1 call $moonbit.init_array16
#| local.get 0)
"#;

pub(crate) const PTR2INT_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2int_array(ptr : Int, len : Int) -> FixedArray[Int] =
Expand All @@ -186,6 +219,15 @@ extern "wasm" fn mbt_ffi_ptr2int_array(ptr : Int, len : Int) -> FixedArray[Int]
#| local.get 0)
"#;

pub(crate) const PTR2INT16_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2int16_array(ptr : Int, len : Int) -> FixedArray[Int16] =
#|(func (param i32) (param i32) (result i32)
#| local.get 0
#| local.get 1 call $moonbit.init_array16
#| local.get 0)
"#;

pub(crate) const PTR2FLOAT_ARRAY: &str = r#"
///|
extern "wasm" fn mbt_ffi_ptr2float_array(ptr : Int, len : Int) -> FixedArray[Float] =
Expand Down
Loading
Loading