Fix handling of context slots in component compositions - #14139
Merged
alexcrichton merged 1 commit intoAug 14, 2026
Conversation
This commit fixes handling of `context.{get,set}` slots in sync-to-sync
adapters generated by Wasmtime's FACT pass. Previously no care was taken
here meaning that the context slots were wrong for `post-return` and
`realloc` calls. All slots are now managed as they are on the host,
mirroring the logic internally for management.
dicej
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes handling of
context.{get,set}slots in sync-to-sync adapters generated by Wasmtime's FACT pass. Previously no care was taken here meaning that the context slots were wrong forpost-returnandrealloccalls. All slots are now managed as they are on the host, mirroring the logic internally for management.