perf: cranelift-codegen-meta: less llvm-lines: strings.join(" ") and iterators - #14127
Draft
dishmaker wants to merge 1 commit into
Draft
perf: cranelift-codegen-meta: less llvm-lines: strings.join(" ") and iterators#14127dishmaker wants to merge 1 commit into
strings.join(" ") and iterators#14127dishmaker wants to merge 1 commit into
Conversation
github-actions
Bot
added
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-2.2%llvm linesDisplayJoined.chain(...)format_args!infmt.add_blockcallsThis PR might be controversial, because anywhere in the code just one:
strings.join(" ")instead ofstrings.display_join(" ")adds back the 1254 llvm-lines that I managed to remove 😐
(but that's still a
-1.5%win).