Skip to content

Fix PartialEq for component model types - #13997

Merged
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
alexcrichton:fix-partial-eq
Jul 27, 2026
Merged

Fix PartialEq for component model types#13997
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
alexcrichton:fix-partial-eq

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

The previous implementation derived PartialEq which tested for semantic equality of maps internally, but the intended implementation is to test for equality of order of items/names as well.

Closes #13994

The previous implementation derived `PartialEq` which tested for
semantic equality of maps internally, but the intended implementation is
to test for equality of order of items/names as well.
@alexcrichton
alexcrichton requested a review from a team as a code owner July 27, 2026 18:01
@alexcrichton
alexcrichton requested review from pchickey and removed request for a team July 27, 2026 18:01
@alexcrichton
alexcrichton added this pull request to the merge queue Jul 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 27, 2026
@alexcrichton
alexcrichton added this pull request to the merge queue Jul 27, 2026
Merged via the queue into bytecodealliance:main with commit dd86f66 Jul 27, 2026
53 checks passed
@alexcrichton
alexcrichton deleted the fix-partial-eq branch July 27, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed CI build for refs/heads/main

2 participants