Add fiber implementation for LoongArch64#13675
Open
heiher wants to merge 2 commits into
Open
Conversation
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Thanks! Could you add a check to this matrix that this crate builds on loongarch64?
Additionally, to confirm, have you run the fiber tests locally and double-checked they're passing?
prtest:platform-checks
Author
Thanks! Done.
Yes, I've run the fiber tests locally and they all passed. |
Comment on lines
-659
to
+664
| run: | | ||
| curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash | ||
| cargo binstall --no-confirm cross | ||
| run: cargo install cross --git https://github.com/cross-rs/cross |
Member
There was a problem hiding this comment.
Does the published release of cross not support loongarch64? If so could this run cargo check insetad of cross build?
(switching to cargo install makes CI more flaky and take longer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LoongArch64 fiber support for Wasmtime.
This fixes the runtime error:
fibers not supported on this host architectureby implementing the required stack switching and unwind support for LoongArch64.
Procedure Call Standard for the LoongArch™ Architecture: https://github.com/loongson/la-abi-specs/blob/release/lapcs.adoc#processor-architecture