Skip to content

wasmtime-jit-icache-coherence: Use wasmtime_environ::error instead of anyhow #12207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 2 commits into from
Dec 24, 2025
+8 −8
Merged

wasmtime-jit-icache-coherence: Use wasmtime_environ::error instead of anyhow #12207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
799cea7
wasmtime-jit-icache-coherence: Use `wasmtime_environ::error` instead …
fitzgen Dec 22, 2025
3e67519
Fix topo sort in publish script
fitzgen Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/jit-icache-coherence/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ workspace = true

[dependencies]
cfg-if = { workspace = true }
anyhow = { workspace = true }
wasmtime-environ = { workspace = true }

[target.'cfg(target_os = "windows")'.dependencies.windows-sys]
workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/jit-icache-coherence/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
//! # len: usize,
//! # }
//! #
//! # fn main() -> anyhow::Result<()> {
//! # fn main() -> wasmtime_environ::error::Result<()> {
//! #
//! # let run_code = || {};
//! # let code = vec![0u8; 64];
Expand Down
4 changes: 2 additions & 2 deletions crates/jit-icache-coherence/src/libc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::ffi::c_void;
pub use std::io::Result;

#[cfg(not(any(target_os = "linux", target_os = "android")))]
pub use anyhow::Result;
pub use wasmtime_environ::error::Result;

#[cfg(all(
target_arch = "aarch64",
Expand Down Expand Up @@ -93,7 +93,7 @@ mod details {
any(target_os = "linux", target_os = "android")
)))]
mod details {
// NB: this uses `anyhow::Result` instead of `std::io::Result` to compile on
// NB: this uses `wasmtime_environ::error::Result` instead of `std::io::Result` to compile on
// `no_std`.
pub(crate) fn pipeline_flush_mt() -> super::Result<()> {
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion crates/jit-icache-coherence/src/miri.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pub use anyhow::Result;
use std::ffi::c_void;
pub use wasmtime_environ::error::Result;

pub(crate) fn pipeline_flush_mt() -> Result<()> {
Ok(())
Expand Down
4 changes: 2 additions & 2 deletions scripts/publish.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ const CRATES_TO_PUBLISH: &[&str] = &[
"cranelift-native",
"cranelift-object",
"cranelift-interpreter",
"wasmtime-internal-component-util",
"wasmtime-environ",
"wasmtime-internal-jit-icache-coherence",
// Wasmtime unwinder, used by both `cranelift-jit` (optionally) and filetests, and by Wasmtime.
"wasmtime-internal-unwinder",
Expand All @@ -56,8 +58,6 @@ const CRATES_TO_PUBLISH: &[&str] = &[
"wasmtime-internal-error",
"wasmtime-internal-versioned-export-macros",
"wasmtime-internal-slab",
"wasmtime-internal-component-util",
"wasmtime-environ",
"wasmtime-internal-wit-bindgen",
"wasmtime-internal-component-macro",
"wasmtime-internal-jit-debug",
Expand Down