fix(resolver,config): remove references to root package in override dependencies#202
Open
mkatychev wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix(resolver,config): remove references to root package in override dependencies#202mkatychev wants to merge 1 commit intobytecodealliance:mainfrom
mkatychev wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
…package currently being built
mkatychev
commented
Apr 24, 2026
Comment on lines
+733
to
+737
| // handle cases for a workspace level `wkg.toml` where overrides may reference | ||
| // the package being built | ||
| if package.main.name == root.main.name { | ||
| continue; | ||
| } |
Member
Author
There was a problem hiding this comment.
Not sure if this or perhaps resolve_dependencies is the best place to handle this case but this should apply to local or registry packages regardless if the dependency name+namespace+version match that of the root:
wasm-pkg-tools/crates/wasm-pkg-core/src/wit.rs
Lines 180 to 212 in 0d3b316
My one concern is the comment on L180 making the
get_pacakges move from L212 tricky.
[overrides] references to self
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently having a "workspace" level
wkg.tomlis not possible since for any package being built, they will also show up as a dependency in the config: